Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid failing when debug artifacts can't be uploaded #2349

Merged
merged 2 commits into from
Jun 22, 2024

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Jun 20, 2024

Failing to upload debug artifacts should not fail the action since it is possible that the action has already succeeded by the time this failure occurs.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • [n/a] Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner June 20, 2024 18:35
@aeisenberg aeisenberg added the Rebuild Re-transpile JS & re-generate workflows label Jun 20, 2024
@github-actions github-actions bot removed the Rebuild Re-transpile JS & re-generate workflows label Jun 20, 2024
Failing to upload debug artifacts should not fail the action since
it is possible that the action has already succeeded by the time this
failure occurs.
@aeisenberg aeisenberg force-pushed the aeisenberg/no-fail-upload-artifacts branch from 24e7d63 to 9507482 Compare June 20, 2024 19:06
angelapwen
angelapwen previously approved these changes Jun 21, 2024
@angelapwen
Copy link
Contributor

Maybe we should add a note in the changelog about this change? 💭

NlightNFotis
NlightNFotis previously approved these changes Jun 21, 2024
Copy link
Member

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, a warning for this is good behaviour IMO.

@aeisenberg
Copy link
Contributor Author

Maybe we should add a note in the changelog about this change? 💭

Yes. We should. I meant too....but forgot.

@aeisenberg aeisenberg dismissed stale reviews from NlightNFotis and angelapwen via e572852 June 21, 2024 18:50
auto-merge was automatically disabled June 21, 2024 18:53

Pull Request is not mergeable

@aeisenberg aeisenberg merged commit 3ce5d00 into main Jun 22, 2024
302 checks passed
@aeisenberg aeisenberg deleted the aeisenberg/no-fail-upload-artifacts branch June 22, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants